Feature/issue 1087 - #1164
Conversation
…#1087) Signed-off-by: Riyanshi Gupta <riyanshigupta890@gmail.com>
|
@riyanshigupta890-cloud is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the work you've put into improving the Saved Projects/bookmarking feature and for following the PR template. The intended UI improvements, responsive layout, hover effects, and persistence workflow are valuable additions.
However, I can't approve this PR in its current state because the diff contains significantly more changes than the PR description and assigned issue require.
The PR currently modifies 11 files and includes changes related to recommendation configuration, recently-viewed functionality, recommender/config files, tests, and other existing functionality. These appear unrelated to the Saved Projects styling/enhancement described in this PR.
There are also merge conflicts with the current main branch.
Please:
- Sync/rebase your branch with the latest
mainand resolve all merge conflicts. - Remove unrelated changes that are already present in
mainor belong to other features/issues. - Keep this PR focused only on the changes required for issue #1087.
- Verify the final "Files changed" diff before requesting another review.
- Re-test bookmarking persistence and the Saved Projects UI after resolving the conflicts.
- Make sure no existing recently-viewed or recommendation functionality is unintentionally modified.
For GSSoC contributions, please keep PRs scoped strictly to the assigned issue. This helps us review and merge contributions safely without accidentally overwriting work from other contributors.
Thank you for the time and effort you've invested in this contribution. Once the branch is updated and the unrelated changes are removed, please request another review and I'll be happy to check it again.
Summary [required]
Finalized the Saved Projects bookmarking feature with enhanced styling.
Related Issue [required]
Closes #1087
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
src/static/bookmarks.csswith comprehensive grid layoutHow to Test This PR [required]
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
None