Skip to content

Feature/issue 1087 - #1164

Open
riyanshigupta890-cloud wants to merge 6 commits into
komalharshita:mainfrom
riyanshigupta890-cloud:feature/issue-1087
Open

Feature/issue 1087#1164
riyanshigupta890-cloud wants to merge 6 commits into
komalharshita:mainfrom
riyanshigupta890-cloud:feature/issue-1087

Conversation

@riyanshigupta890-cloud

@riyanshigupta890-cloud riyanshigupta890-cloud commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary [required]

Finalized the Saved Projects bookmarking feature with enhanced styling.

Related Issue [required]

Closes #1087

Type of Change [required]

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

  • Enhanced src/static/bookmarks.css with comprehensive grid layout
  • Added hover effects and smooth transitions
  • Implemented responsive design for saved projects panel

How to Test This PR [required]

  1. Enter skills and preferences on homepage
  2. Click "Generate My Projects"
  3. Click heart icon on any project to save
  4. Scroll to "Saved Projects" section
  5. Refresh page to verify persistence

Self-Review Checklist [required]

  • I have read CONTRIBUTING.md and followed all guidelines
  • My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • I have run python tests/test_basic.py and all 27 tests pass
  • I have run flake8 . locally and there are no errors
  • I have not introduced any print() or console.log() debug statements
  • Every new function I wrote has a docstring
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

None

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

@riyanshigupta890-cloud is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@komalharshita komalharshita left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work you've put into improving the Saved Projects/bookmarking feature and for following the PR template. The intended UI improvements, responsive layout, hover effects, and persistence workflow are valuable additions.

However, I can't approve this PR in its current state because the diff contains significantly more changes than the PR description and assigned issue require.

The PR currently modifies 11 files and includes changes related to recommendation configuration, recently-viewed functionality, recommender/config files, tests, and other existing functionality. These appear unrelated to the Saved Projects styling/enhancement described in this PR.

There are also merge conflicts with the current main branch.

Please:

  1. Sync/rebase your branch with the latest main and resolve all merge conflicts.
  2. Remove unrelated changes that are already present in main or belong to other features/issues.
  3. Keep this PR focused only on the changes required for issue #1087.
  4. Verify the final "Files changed" diff before requesting another review.
  5. Re-test bookmarking persistence and the Saved Projects UI after resolving the conflicts.
  6. Make sure no existing recently-viewed or recommendation functionality is unintentionally modified.

For GSSoC contributions, please keep PRs scoped strictly to the assigned issue. This helps us review and merge contributions safely without accidentally overwriting work from other contributors.

Thank you for the time and effort you've invested in this contribution. Once the branch is updated and the unrelated changes are removed, please request another review and I'll be happy to check it again.

@komalharshita komalharshita added enhancement New feature or request need review Further information is requested level:intermediate quality:clean type:feature labels Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Implement Saved Projects (Bookmarking System)

2 participants